FIX - Inspect floater VRAM estimate can overshoot by a lot#216
Open
trish-sl wants to merge 1 commit intoFirestormViewer:masterfrom
Open
FIX - Inspect floater VRAM estimate can overshoot by a lot#216trish-sl wants to merge 1 commit intoFirestormViewer:masterfrom
trish-sl wants to merge 1 commit intoFirestormViewer:masterfrom
Conversation
trish-sl
force-pushed
the
fix-vramestimate
branch
from
b7769c4 to
4dd88d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inspect floater VRAM's way of calculating VRAM usage is to currently guess the vram usage by doing width * height * 32bit (cause textures are RGBA32) / 8 to convert to bytes. This is a "worst possible outcome" estimate. This can boost the reported VRAM usage by two times in some use cases. This estimation exaggeration can make 2k PBR materials look disproportionally bad on paper.
The floater should just take the actual (allocated GL) memory instead, for a closer estimate. This reports a much more accurate number.
just one example with one of my objects, but you can try with your own.
before with fixed estimate: https://gyazo.com/f405634ad5911aa2ca26861c64b68f36
now with memory read: https://gyazo.com/1d78c2eaf67253316afd9edc4a404e79